Skip to content

chore: clean up unused imports and variables#123

Merged
rexlunae merged 1 commit intomainfrom
fix/cleanup-unused-warnings
Mar 20, 2026
Merged

chore: clean up unused imports and variables#123
rexlunae merged 1 commit intomainfrom
fix/cleanup-unused-warnings

Conversation

@rexlunae
Copy link
Copy Markdown
Owner

@rexlunae rexlunae commented Mar 20, 2026

Summary

Removes all unused import/variable warnings from rustyclaw-core.

Why This Matters

Unused import warnings force the compiler to search the entire codebase for potential use sites, which:

  • Increases compile times
  • Slows down CI
  • Makes build output noisy

Changes

  • thinking_clock.rs: remove unused warn import
  • threads/manager.rs: remove unused ThreadKind and warn imports
  • gateway/mod.rs: prefix unused model_task_tx with underscore
  • threads/subtask.rs: prefix unused join_handle field with underscore

Result

cargo check -p rustyclaw-core
# No warnings!

Open with Devin

Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 3 additional findings.

Open in Devin Review

Remove unused warnings from rustyclaw-core lib:
- thinking_clock.rs: remove unused 'warn' import
- threads/manager.rs: remove unused 'ThreadKind' (add to test module) and 'warn' imports
- gateway/mod.rs: prefix unused 'model_task_tx' with underscore
- threads/subtask.rs: prefix unused '_join_handle' field and construction sites

Unused import warnings force the compiler to search the entire codebase
for potential use sites, which increases compile times and CI duration.
@rexlunae rexlunae force-pushed the fix/cleanup-unused-warnings branch from 862a083 to 8ad10b1 Compare March 20, 2026 19:02
@rexlunae rexlunae merged commit 2107d85 into main Mar 20, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant